Add FromFile to BinaryData #107231
Merged
Add FromFile to BinaryData #107231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
reviewed
Sep 2, 2024
lilinus
reviewed
Sep 2, 2024
stephentoub
reviewed
Sep 4, 2024
This was referenced Sep 5, 2024
stephentoub
reviewed
Nov 8, 2024
stephentoub
reviewed
Nov 8, 2024
stephentoub
reviewed
Nov 8, 2024
stephentoub
reviewed
Nov 8, 2024
manandre
force-pushed
the
binarydata-fromfile
branch
from
8f9e37f to
93ed01b
Compare
stephentoub
reviewed
Nov 9, 2024
stephentoub
reviewed
Nov 9, 2024
stephentoub
reviewed
Nov 9, 2024
src/libraries/System.Memory.Data/tests/BinaryDataFromFileTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 9, 2024
stephentoub
reviewed
Nov 9, 2024
Open
3 tasks
stephentoub
approved these changes
Nov 10, 2024
Member
|
/ba-g unrelated timeouts |
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* Add FromFile to BinaryData
* Cleanup temporary files
* Use FileStream async mode
* Avoid code duplication
* Use test helpers
* Use ReadAllBytes{Async} where possible
* Async wrapper
* Tests cleaning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106203